linux-kernel - Re: [uml-devel] [PATCH 6/6] UML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 24 Aug 2007 18:10:24 +0200
From:	Blaisorblade <blaisorblade@...oo.it>
To:	user-mode-linux-devel@...ts.sourceforge.net
Cc:	Jeff Dike <jdike@...toit.com>, Andrew Morton <akpm@...l.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Satyam Sharma <satyam@...radead.org>,
	Joe Perches <joe@...ches.com>
Subject: Re: [uml-devel] [PATCH 6/6] UML - Fix hostfs style

On venerdì 24 agosto 2007, Jeff Dike wrote:
> On Thu, Aug 23, 2007 at 04:54:59PM +0200, Blaisorblade wrote:
> > > actually. Personally I'd prefer:
> > >
> > > 	else
> > > 		type = OS_TYPE_DIR;
> >
> > I strongly agree with this style; beyond style itself, one strong reason
> > is that joining statements hinder singlestepping through function code
> > (it's easy to run gdb on UML, and anyway kgdb exists).
>
> How does that help?  gdb should stop as easily on a "else foo;" line as on
> 	else
> 		foo;
> right?
Sorry, a better example is on:

	if (bar)
		foo;
where the test and foo are two distinct parts. One step is "I execute the if", 
another (possible) step is "I perform foo" - which is not easy to tell if it 
is not on a different line.
-- 
"Doh!" (cit.), I've made another mistake!
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade

Download attachment "signature.asc " of type "application/pgp-signature" (190 bytes)