linux-kernel - Re: false positive in checkpatch.pl (complex macro values)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 24 Aug 2007 15:10:40 -0400
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Josef Sipek" <jsipek@....cs.sunysb.edu>
Cc:	"SL Baur" <steve@...acs.org>, "Andy Whitcroft" <apw@...dowen.org>,
	"Linux Kernel" <linux-kernel@...r.kernel.org>,
	"Michael Hennerich" <michael.hennerich@...log.com>
Subject: Re: false positive in checkpatch.pl (complex macro values)

On 8/24/07, Josef Sipek <jsipek@....cs.sunysb.edu> wrote:
> On Fri, Aug 24, 2007 at 09:24:17AM -0400, Mike Frysinger wrote:
> ...
> > $ grep AUREON_DEVICE_DESC ./sound/pci/ice1712/aureon.h -A 5
> > #define  AUREON_DEVICE_DESC            "{Terratec,Aureon 5.1 Sky},"\
> >                                        "{Terratec,Aureon 7.1 Space},"\
> >                                        "{Terratec,Aureon 7.1 Universe}," \
> >                                         "{AudioTrak,Prodigy 7.1}," \
> >                                         "{AudioTrak,Prodigy 7.1 LT},"\
> >                                         "{AudioTrak,Prodigy 7.1 XT},"
>
> This is a different thing. This is a long string, not a list of elements.
> IMO, this one shouldn't have given a warning regardless of whether or not
> the original case is valid.

i did point out that grepping the tree shows plenty of results ... if
this one is not satisfactory, you're free to grep to locate ones that
are

the code we're using is used to initialize a data structure ... you
can find similar things in:
./sound/ppc/tumbler.c
./sound/pci/emu10k1/p16v.c
./sound/pci/hda/patch_realtek.c
./sound/pci/hda/patch_si3054.c
./sound/usb/usbquirks.h
./sound/oss/sscape.c
and then i hit ctrl+c
-mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/