linux-kernel - Re: [PATCH] clean up exports in fs/{open,read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Aug 2007 15:49:01 -0700
From:	Arjan van de Ven <arjan@...ux.intel.com>
To:	Christoph Hellwig <hch@...radead.org>,
	Eugene Teo <eugeneteo@...nel.sg>, linux-kernel@...r.kernel.org,
	Takashi Iwai <tiwai@...e.de>,
	Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: [PATCH] clean up exports in fs/{open,read_write}.c

Christoph Hellwig wrote:
> On Fri, Aug 24, 2007 at 11:33:10AM +0800, Eugene Teo wrote:
>> Takashi-san fixed sound/isa/wavefront/wavefront_synth.c to use
>> request_firmware instead of sys_*. Since that is the last driver in the
>> kernel that uses sys_{read,close}, this patch kills these exports. sys_open
>> is left exported for sparc64 only.
> 
> I can't find any spar user of it, so please kill it.  

it's in the solaris compat code which is modular


> In the case a symbol
> is needed only for a particular architecture it's better to do it in the
> architecture-specific ksyms file than with an ifdef, btw.

agreed.
(well if it's only 1 or 2, if it's "half of them" it's obviously a 
different story)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/