linux-kernel - Re: [PATCH] input: Silence 'unused variable' warning in iforce joystick driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 31 Aug 2007 04:27:13 +0530 (IST)
From:	Satyam Sharma <satyam@...radead.org>
To:	Jesper Juhl <jesper.juhl@...il.com>
cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Vojtech Pavlik <vojtech@....cz>,
	Johann Deneux <johann.deneux@...il.com>, dtor@...l.ru,
	linux-input@...ey.karlin.mff.cuni.cz,
	linux-joystick@...ey.karlin.mff.cuni.cz
Subject: Re: [PATCH] input: Silence 'unused variable' warning in iforce
 joystick driver

Hi,


On Fri, 31 Aug 2007, Jesper Juhl wrote:

> In the iforce driver we currently get this warning
> 
>  drivers/input/joystick/iforce/iforce-packets.c: In function 'iforce_get_id_packet':
>  drivers/input/joystick/iforce/iforce-packets.c:249: warning: unused variable 'status'
> 
> if CONFIG_JOYSTICK_IFORCE_USB is not defined.
> 
> The warning is easy to avoid by simply moving the variable inside 
> the only case in the switch that actually use it.
> 
> 
> Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>
> ---
> 
> diff --git a/drivers/input/joystick/iforce/iforce-packets.c b/drivers/input/joystick/iforce/iforce-packets.c
> index 3154ccd..48d4a86 100644
> --- a/drivers/input/joystick/iforce/iforce-packets.c
> +++ b/drivers/input/joystick/iforce/iforce-packets.c
> @@ -246,13 +246,12 @@ void iforce_process_packet(struct iforce *iforce, u16 cmd, unsigned char *data)
>  
>  int iforce_get_id_packet(struct iforce *iforce, char *packet)
>  {
> -	int status;
> -
>  	switch (iforce->bus) {
>  
>  	case IFORCE_USB:
> -
>  #ifdef CONFIG_JOYSTICK_IFORCE_USB
> +		int status;
> +
>  		iforce->cr.bRequest = packet[0];
>  		iforce->ctrl->dev = iforce->usbdev;

Hmm, would this not still give a warning when JOYSTICK_IFORCE_USB=y?
[ I didn't know mixing code and declarations (not at top of statement
  block) was accepted style in the kernel ... ]

IMHO either you should at least wrap that case inside a {} of its
own (so that the int status; is at top of a statement block), or else,
preferably, just add "__maybe_unused" to the first declaration that you
removed just now.


Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/