linux-kernel - Re: [PATCH] Track accurate idle time with tick_sched.idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	02 Sep 2007 00:23:53 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Venki Pallipadi <venkatesh.pallipadi@...el.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Track accurate idle time with tick_sched.idle_sleeptime

Venki Pallipadi <venkatesh.pallipadi@...el.com> writes:
>  
> +void tick_nohz_stop_idle(int cpu)
> +{
> +	struct tick_sched *ts = &per_cpu(tick_cpu_sched, cpu);
> +
> +	if (ts->idle_active) {
> +		ktime_t now, delta;
> +		now = ktime_get();

That could be PM timer read costing thousands of cycles.

For going into idle it's probably not a real problem, but it could
seriously affect out of idle latencies.

You would really need a cheaper per CPU timer that doesn't
stop in idle (which rules out sched_clock). It's all unfortunately
quite messy.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/