linux-kernel - Re: [PATCH -mm] [RFC] IOAT: Add support for version 2 of ioatdma device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 7 Sep 2007 09:43:22 +0100
From:	Andy Whitcroft <apw@...dowen.org>
To:	Shannon Nelson <shannon.nelson@...el.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm] [RFC] IOAT: Add support for version 2 of ioatdma device

On Thu, Sep 06, 2007 at 10:07:12AM -0700, Shannon Nelson wrote:
>  	list_for_each_entry(iter, &desc->async_tx.tx_list, node) {
>  		iter->hw->src_addr = addr;
>  		addr += ioat_chan->xfercap;
> +
> +		if (--cnt == 0);
> +			break;
>  	}
>  
>  }
> @@ -166,20 +177,28 @@ static void ioat_set_dest(dma_addr_t addr,
>  {
>  	struct ioat_desc_sw *iter, *desc = tx_to_ioat_desc(tx);
>  	struct ioat_dma_chan *ioat_chan = to_ioat_chan(tx->chan);
> +	int cnt = desc->tx_cnt;
>  
>  	pci_unmap_addr_set(desc, dst, addr);
>  
>  	list_for_each_entry(iter, &desc->async_tx.tx_list, node) {
>  		iter->hw->dst_addr = addr;
>  		addr += ioat_chan->xfercap;
> +
> +		if (--cnt == 0);
> +			break;
>  	}

Those two look suspect to checkpatch, and I have to agree with it.

WARNING: Trailing semicolon indicates no statements, indent implies
otherwise
#346: FILE: drivers/dma/ioat_dma.c:168:
+               if (--cnt == 0);
+                       break;
WARNING: Trailing semicolon indicates no statements, indent implies
otherwise
#363: FILE: drivers/dma/ioat_dma.c:188:
+               if (--cnt == 0);
+                       break;

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/