lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Sep 2007 12:02:20 +0000 From: Pavel Machek <pavel@....cz> To: Stephen Hemminger <shemminger@...ux-foundation.org> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>, Len Brown <lenb@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>, linux-input@...ey.karlin.mff.cuni.cz, linux-kernel@...r.kernel.org Subject: Re: [PATCH] fujtisu application panel driver Hi! > > Thank you very much for updating the patch. I have a couple of requests though: > > > > 1. LEDs shoud use the generic led subsystem instead of input layer. I > > do not have plans of adding any more LED_XXX constants and I think > > that adding any LEDs not directly relating to keyboard state was a > > mistake. > > No, way to much work for one stinking LED. 'Lets do it wrong way because right way is too much work'? Come on... doing let driver is 30 minutes and 100-or-so lines of code. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists