linux-kernel - Re: Fix "no_sync_cmos_clock" logic inversion in kernel/time/ntp.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 11 Sep 2007 09:57:50 +0200
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Tony Breeds <tony@...eyournoodle.com>
Cc:	Linux Kernel ML <linux-kernel@...r.kernel.org>,
	LinuxPPC-dev <linuxppc-dev@...abs.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Paul Mackerras <paulus@...ba.org>,
	Gabriel Paubert <paubert@...m.es>, zach@...are.com,
	John Stultz <johnstul@...ibm.com>
Subject: Re: Fix "no_sync_cmos_clock"  logic inversion in kernel/time/ntp.c

On Tue, 2007-09-11 at 17:46 +1000, Tony Breeds wrote:
> Signed-off-by: Tony Breeds <tony@...eyournoodle.com>
> 
> ---
> 
> Seems to me that this timer will only get started on platforms that say
> they don't want it?

Hell, yes. Good catch !

	tglx

>  kernel/time/ntp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: working/kernel/time/ntp.c
> ===================================================================
> --- working.orig/kernel/time/ntp.c	2007-09-11 17:34:44.000000000 +1000
> +++ working/kernel/time/ntp.c	2007-09-11 17:34:55.000000000 +1000
> @@ -226,7 +226,7 @@ static void sync_cmos_clock(unsigned lon
>  
>  static void notify_cmos_timer(void)
>  {
> -	if (no_sync_cmos_clock)
> +	if (!no_sync_cmos_clock)
>  		mod_timer(&sync_cmos_timer, jiffies + 1);
>  }
>  
> 
> Yours Tony
> 
>   linux.conf.au        http://linux.conf.au/ || http://lca2008.linux.org.au/
>   Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/