lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 13 Sep 2007 02:42:43 -0400 From: Jeff Garzik <jeff@...zik.org> To: Alexey Dobriyan <adobriyan@...il.com> CC: Andrew Morton <akpm@...ux-foundation.org>, Greg KH <greg@...ah.com>, Kees Cook <kees@...ntu.com>, linux-kernel@...r.kernel.org, Ben Collins <bcollins@...ntu.com>, Michael Wu <flamingice@...rmilk.net> Subject: Re: [PATCH] pci: fix unterminated pci_device_id lists Alexey Dobriyan wrote: > -static struct pci_device_id rtl8139_pci_tbl[] = { > +PCI_MODULE_DEVICE_TABLE_BEGIN(rtl8139_pci_tbl) > {0x10ec, 0x8139, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 }, > {0x10ec, 0x8138, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 }, > {0x1113, 0x1211, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 }, > @@ -273,10 +273,7 @@ static struct pci_device_id rtl8139_pci_tbl[] = { > {PCI_ANY_ID, 0x8139, 0x10ec, 0x8139, 0, 0, RTL8139 }, > {PCI_ANY_ID, 0x8139, 0x1186, 0x1300, 0, 0, RTL8139 }, > {PCI_ANY_ID, 0x8139, 0x13d1, 0xab06, 0, 0, RTL8139 }, > - > - {0,} > -}; > -MODULE_DEVICE_TABLE (pci, rtl8139_pci_tbl); > +PCI_MODULE_DEVICE_TABLE_END I think the previous version looks better. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists