linux-kernel - Re: EDD still failing on some systems with 2.6.23-rc6-git2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 17 Sep 2007 08:32:24 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Chuck Ebbert <cebbert@...hat.com>
CC:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: EDD still failing on some systems with 2.6.23-rc6-git2

Chuck Ebbert wrote:
> 
> Still fails. And apparently fails on disk 0, because it hangs right
> after printing a zero:
> 
> --- linux-2.6.22.noarch.orig/arch/i386/boot/edd.c
> +++ linux-2.6.22.noarch/arch/i386/boot/edd.c
> @@ -151,6 +151,7 @@ void query_edd(void)
>                  * Scan the BIOS-supported hard disks and query EDD
>                  * information...
>                  */
> +               putchar('0' + (devno - 0x80) % 10);
>                 get_edd_info(devno, &ei);
> 
>                 if (boot_params.eddbuf_entries < EDDMAXNR) {

You know... we actually do have printf()... you don't have to play this
kind of games; you can just printf("Drive %x...\n", devno);

So does this happen ONLY when booting from CD-ROM, or is there any other
case when it fails, too?

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/