linux-kernel - Re: 2.6.23-rc4-mm1 compile error for ppc 32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 18 Sep 2007 02:14:27 +0530
From:	Balbir Singh <balbir@...ux.vnet.ibm.com>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
CC:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Nick Piggin <nickpiggin@...oo.com.au>,
	linux-kernel@...r.kernel.org,
	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Subject: Re: 2.6.23-rc4-mm1 compile error for ppc 32

Benjamin Herrenschmidt wrote:
> On Sat, 2007-09-15 at 11:00 -0400, Mathieu Desnoyers wrote:
>> * Benjamin Herrenschmidt (benh@...nel.crashing.org) wrote:
>>> On Thu, 2007-09-13 at 15:17 -0700, Andrew Morton wrote:
>>>
>>>> Like this?
>>>>
>>>> --- a/include/asm-powerpc/bitops.h~powerpc-lock-bitops-fix
>>>> +++ a/include/asm-powerpc/bitops.h
>>>> @@ -226,7 +226,7 @@ static __inline__ void set_bits(unsigned
>>>>  
>>>>  static __inline__ void __clear_bit_unlock(int nr, volatile unsigned long *addr)
>>>>  {
>>>> -	__asm__ __volatile__(LWSYNC_ON_SMP ::: "memory");
>>>> +	__asm__ __volatile__(LWSYNC_ON_SMP "" ::: "memory");
>>>>  	__clear_bit(nr, addr);
>>>>  }
>>>>  
>>> Looks ok. Can somebody test ? I'm still travelling...
>>>
>>>
>> Hi Benjamin,
>>
>> With this patch and hrtimer.c fixes, 2.6.23-rc4-mm1 PPC arch (for
>> powerpc 405) compiles fine.
>>
>> I still see errors/warnings from modpost though:
> 
> Looks like the legacy ISA DMA crap no ? I don't know much about it.
> 
> Ben.
> 

Kamalesh has reported a similar bug and is looking to fix this problem.
He's been looking at Kconfig's to see that all of them either
depend on GENERIC_ISA_DMA or select it.

>> make -f /home/compudj/git/linux-2.6-lttng/scripts/Makefile.modpost
>>   scripts/mod/modpost -m  -o /home/compudj/obj/powerpc-405/Module.symvers    -s
>> ERROR: "request_dma" [sound/oss/sscape.ko] undefined!
>> ERROR: "free_dma" [sound/oss/sscape.ko] undefined!
>> ERROR: "dma_spin_lock" [sound/oss/sscape.ko] undefined!
>> ERROR: "free_dma" [sound/oss/sound.ko] undefined!
>> ERROR: "request_dma" [sound/oss/sound.ko] undefined!
>> ERROR: "dma_spin_lock" [sound/oss/sound.ko] undefined!
>> ERROR: "dma_spin_lock" [sound/core/snd.ko] undefined!
>> ERROR: "dma_spin_lock" [net/irda/irda.ko] undefined!
>> WARNING: "div64_64" [net/ipv4/tcp_cubic.ko] has no CRC!
>> ERROR: "free_dma" [drivers/parport/parport_pc.ko] undefined!
>> ERROR: "request_dma" [drivers/parport/parport_pc.ko] undefined!
>> ERROR: "dma_spin_lock" [drivers/parport/parport_pc.ko] undefined!
>> ERROR: "request_dma" [drivers/net/irda/w83977af_ir.ko] undefined!
>> ERROR: "free_dma" [drivers/net/irda/w83977af_ir.ko] undefined!
>> ERROR: "request_dma" [drivers/net/irda/via-ircc.ko] undefined!
>> ERROR: "free_dma" [drivers/net/irda/via-ircc.ko] undefined!
>> ERROR: "request_dma" [drivers/net/irda/smsc-ircc2.ko] undefined!
>> ERROR: "free_dma" [drivers/net/irda/smsc-ircc2.ko] undefined!
>> ERROR: "free_dma" [drivers/net/irda/nsc-ircc.ko] undefined!
>> ERROR: "request_dma" [drivers/net/irda/nsc-ircc.ko] undefined!
>> ERROR: "free_dma" [drivers/net/irda/ali-ircc.ko] undefined!
>> ERROR: "request_dma" [drivers/net/irda/ali-ircc.ko] undefined!
>> ERROR: "request_dma" [drivers/mmc/host/wbsd.ko] undefined!
>> ERROR: "dma_spin_lock" [drivers/mmc/host/wbsd.ko] undefined!
>> ERROR: "free_dma" [drivers/mmc/host/wbsd.ko] undefined!
>>
>> Mathieu
>>
-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/