linux-kernel - Re: 2.6.23-rc6-mm1 - make access to tasks nsproxy ligther (fix)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Sep 2007 11:12:13 +0200
From:	Cedric Le Goater <clg@...ibm.com>
To:	Pavel Emelyanov <xemul@...nvz.org>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, "Serge E. Hallyn" <serue@...ibm.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Oleg Nesterov <oleg@...sign.ru>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: 2.6.23-rc6-mm1 - make access to tasks nsproxy ligther (fix)

Pavel Emelyanov wrote:
> Looks sane :)
> 
> [snip]
> 
>> Index: 2.6.23-rc6-mm1/kernel/exit.c
>> ===================================================================
>> --- 2.6.23-rc6-mm1.orig/kernel/exit.c
>> +++ 2.6.23-rc6-mm1/kernel/exit.c
>> @@ -408,6 +408,8 @@ void daemonize(const char *name, ...)
>>  	current->fs = fs;
>>  	atomic_inc(&fs->count);
>>  
>> +	if (current->nsproxy != init_task.nsproxy)
>> +		get_nsproxy(init_task.nsproxy);
>>  	switch_task_namespaces(current, init_task.nsproxy);
> 
> shouldn't we make the switch under this if() as well?

right. we can probably simplify switch_task_namespaces() and remove :

	if (ns == new)
		return;

I'll cook a better one today.

Thanks !

C. 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/