linux-kernel - Re: [PATCH] usb-gadget-ether: Prevent oops caused by error interrupt race -V2 (comments update)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 22 Sep 2007 21:30:40 +0200
From:	Thomas Gleixner <tglx@...utronix.de>
To:	David Brownell <david-b@...bell.net>
Cc:	stable@...nel.org, linux-kernel@...r.kernel.org,
	bene@...utronix.de, akpm@...l.org
Subject: Re: [PATCH] usb-gadget-ether: Prevent oops caused by error
	interrupt  race -V2 (comments update)


On Sat, 2007-09-22 at 12:18 -0700, David Brownell wrote:
> I think you misread my comment.  Those requests are **NOT** pending!!
> So this update has a *MORE* incorrect description of the issue. 
> 
> That's just the freelist ... it's a fairly conventional model whereby
> there's a pool of "free" request slots which can be issued.  When the
> pool empties, the TX queue shuts down until one of the requests which
> is pending in the hardware completes, and makes a slot free.
> 
> The problem you're addressing is that there's a small window where a
> disconnect IRQ can shut down the TX queue (and empty that freelist)
> after upper layers in the network stack started a transmission on
> an active (pre-disconnect) TX queue.
> 
> That problem is *NOT* related to any pending requests at all!!

Sorry, I misunderstood your comment. Can you please add the correct
comment yourself before we play some more rounds of ping pong ? 

	tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/