| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 29 Sep 2007 12:25:30 +0200 From: Jean Delvare <khali@...ux-fr.org> To: LKML <linux-kernel@...r.kernel.org> Cc: Linus Torvalds <torvalds@...ux-foundation.org>, Andrew Morton <akpm@...ux-foundation.org>, David Brownell <david-b@...bell.net> Subject: [PATCH] CodingStyle: Printing numbers in parentheses is fine Remove a not particularly relevant rule from CodingStyle. Sometimes, printing numbers in parentheses doesn't add value, but in some (most?) cases it makes the message easier to read. As a matter of fact, this practice is widely used in the kernel: linux-2.6.23-rc8$ quilt grep -I '(%l*[du])' | wc -l 3166 linux-2.6.23-rc8$ Signed-off-by: Jean Delvare <khali@...ux-fr.org> --- Documentation/CodingStyle | 2 -- 1 file changed, 2 deletions(-) --- linux-2.6.23-rc8.orig/Documentation/CodingStyle 2007-07-23 16:44:32.000000000 +0200 +++ linux-2.6.23-rc8/Documentation/CodingStyle 2007-09-28 23:53:23.000000000 +0200 @@ -638,8 +638,6 @@ concise, clear, and unambiguous. Kernel messages do not have to be terminated with a period. -Printing numbers in parentheses (%d) adds no value and should be avoided. - There are a number of driver model diagnostic macros in <linux/device.h> which you should use to make sure messages are matched to the right device and driver, and are tagged with the right level: dev_err(), dev_warn(), -- Jean Delvare - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists