linux-kernel - Re: MSI: Use correct data offset for 32-bit MSI in read_msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 03 Oct 2007 13:55:10 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Roland Dreier <roland@...italvampire.org>
Cc:	Greg KH <greg@...ah.com>, linux-pci@...ey.karlin.mff.cuni.cz,
	linux-kernel@...r.kernel.org
Subject: Re: MSI: Use correct data offset for 32-bit MSI in read_msi_msg()

Roland Dreier <roland@...italvampire.org> writes:

>  > > While reading the MSI code trying to find a reason why MSI wouldn't
>  > > work for devices that have a 32-bit MSI address capability, I noticed
>  > > that read_msi_msg() seems to read the message data from the wrong
>  > > offset in this case.
>  > 
>  > Doh!  Sorry about that.
>
> Doesn't matter, it wasn't the bug hitting me anyway :) the IRQ never
> got affinity changed so read_msi_msg() never even got called.
>
> I'm starting to think that Intel 945GM graphics just has a busted MSI
> implementation, although there may be a bug hiding in the Linux code
> that I'm not seeing.

Well it is a bug worth fixing.  Who knows it may have something
to do with the disable_irq problems the forcedeth driver was seeing.

Right now MSI is still sufficiently new that everyone is still getting
the bugs out of their implementations.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/