linux-kernel - Re: [patch take 2][Intel-IOMMU] Fix for IOMMU early crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 04 Oct 2007 11:19:33 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	"Keshavamurthy, Anil S" <anil.s.keshavamurthy@...el.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	akpm@...ux-foundation.org, Greg KH <greg@...ah.com>,
	muli@...ibm.com, paulus@...ba.org, kristen.c.accardi@...el.com
Subject: Re: [patch take 2][Intel-IOMMU] Fix for IOMMU early crash

> Index: 2.6-mm/include/linux/pci.h
> ===================================================================
> --- 2.6-mm.orig/include/linux/pci.h	2007-10-03 13:48:20.000000000 -0700
> +++ 2.6-mm/include/linux/pci.h	2007-10-03 13:49:08.000000000 -0700
> @@ -195,6 +195,7 @@
>  #ifdef CONFIG_PCI_MSI
>  	struct list_head msi_list;
>  #endif
> +	void		*iommu_private;	/* hook for IOMMU specific extension */
>  };

I'm not fan of this. That would imply that iommu stuff is specific to
PCI or that sort of thing.

Why don't you use the new struct dev_archdata mechanism ? That's what I
use on powerpc to provide optional iommu linkage to any device in the
system.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/