linux-kernel - Re: [PATCH 2/2] implement new notifier function to panic_notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 05 Oct 2007 15:19:42 +0900
From:	Takenori Nagano <t-nagano@...jp.nec.com>
To:	vgoyal@...ibm.com
CC:	linux-kernel@...r.kernel.org,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	k-miyoshi@...jp.nec.com, kexec@...ts.infradead.org,
	Bernhard Walle <bwalle@...e.de>, Keith Owens <kaos@....com.au>,
	Andrew Morton <akpm@...ux-foundation.org>, kdb@....sgi.com
Subject: Re: [PATCH 2/2] implement new notifier function to panic_notifier_list

Vivek Goyal wrote:
> On Thu, Oct 04, 2007 at 08:38:50PM +0900, Takenori Nagano wrote:
>
>> @@ -522,8 +530,8 @@ setup_arch(char **cmdline_p)
>>  	}
>>
>>  	/* Register a call for panic conditions. */
>> -	atomic_notifier_chain_register(&panic_notifier_list,
>> -			&alpha_panic_block);
>> +	tunable_notifier_chain_register(&panic_notifier_list,
>> +			&alpha_panic_block, "alpha_panic", NULL);
>>
> 
> I think it might be good idea to somehow create provisions for another a
> help string. This help string will inform admin that what a registered
> user does? Ideally this should be visible in /sys/kernel/debug/<user module>/description file.

Hi Vivek,

We can make description file with tunable_notifier_chain_register 4th argument.
If developer sets 4th argument, tunable_notifier_chain_register makes
/sys/kernel/debug/<name>/description file. Admin can get information from the
description file.

+/**
+ *	tunable_notifier_chain_register - Add notifier to an tunable notifier chain
+ *	@nh: Pointer to head of the tunable notifier chain
+ *	@n: New entry in notifier chain
+ *	@name: Pointer to the name of the new notifier entry
+ *	@desc: Pointer to the description of new entry
+ *
+ *	Adds a notifier to an tunable notifier chain and makes control dir.
+ *
+ *	Returns zero on success or %-ENODEV on failure.
+ */

Thanks,

Takenori Nagano <t-nagano@...jp.nec.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/