linux-kernel - [PATCH -mm] Make Smart Battery System depend on ACPI_SBS ACPI_PROC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 09 Oct 2007 17:17:11 +0900
From:	Fernando Luis Vázquez Cao 
	<fernando@....ntt.co.jp>
To:	linux-kernel@...r.kernel.org
Cc:	astarikovskiy@...e.de, vladimir.p.lebedev@...el.com,
	akpm@...ux-foundation.org, len.brown@...el.com
Subject: [PATCH -mm] Make Smart Battery System  depend on ACPI_SBS
	ACPI_PROC_EVENT

Playing with the latest -mm kernel I stumbled upon the following compile
error:

  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  CALL    scripts/checksyscalls.sh
<stdin>:1389:2: warning: #warning syscall revokeat not implemented
<stdin>:1393:2: warning: #warning syscall frevoke not implemented
  CHK     include/linux/compile.h
  LD      drivers/acpi/built-in.o
  LD [M]  drivers/acpi/processor.o
  CC [M]  drivers/acpi/sbs.o
drivers/acpi/sbs.c: In function 'acpi_battery_add':
drivers/acpi/sbs.c:825: warning: ignoring return value of 'device_create_file',\
 declared with attribute warn_unused_result
drivers/acpi/sbs.c: In function 'acpi_sbs_callback':
drivers/acpi/sbs.c:898: error: implicit declaration of function 'acpi_bus_gener\
ate_proc_event4'
make[2]: *** [drivers/acpi/sbs.o] Error 1
make[1]: *** [drivers/acpi] Error 2
make: *** [drivers] Error 2

The problem turned out to be that the sbs module is still using
acpi_bus_generate_proc_event4(), which is part of the
deprecated /proc/acpi/event interface. This patch makes this dependency
explicit.

Signed-off-by: Fernando Luis Vazquez Cao <fernando@....ntt.co.jp>
---

diff -urNp linux-2.6.23-rc8-mm2-orig/drivers/acpi/Kconfig linux-2.6.23-rc8-mm2/drivers/acpi/Kconfig
--- linux-2.6.23-rc8-mm2-orig/drivers/acpi/Kconfig	2007-10-09 17:12:55.000000000 +0900
+++ linux-2.6.23-rc8-mm2/drivers/acpi/Kconfig	2007-10-09 16:36:07.000000000 +0900
@@ -352,6 +352,7 @@ config ACPI_HOTPLUG_MEMORY
 config ACPI_SBS
 	tristate "Smart Battery System (EXPERIMENTAL)"
 	depends on X86
+	depends on ACPI_PROC_EVENT
 	depends on EXPERIMENTAL
 	help
 	  This driver adds support for the Smart Battery System.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/