| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Oct 2007 09:44:16 +0200 From: René Rebe <rene@...ctcode.de> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: Linux 2.6.23 Hi Linus et al., 2.6.23 does not build with my usual .config on x86_64 and gcc-4.2.1: In file included from fs/drop_caches.c:8: include/linux/mm.h:1210: warning: 'struct super_block' declared inside parameter list nclude/linux/mm.h:1210: warning: its scope is only this definition or declaration, which is probably not what you want fs/drop_caches.c:17: error: conflicting types for 'drop_pagecache_sb' include/linux/mm.h:1210: error: previous declaration of 'drop_pagecache_sb' was here fs/drop_caches.c:28: error: conflicting types for 'drop_pagecache_sb' include/linux/mm.h:1210: error: previous declaration of 'drop_pagecache_sb' was here A little forward declaration fixes this: --- linux-2.6.23/include/linux/mm.h.vanilla 2007-10-10 09:28:33.000000000 +0200 +++ linux-2.6.23/include/linux/mm.h 2007-10-10 09:30:23.000000000 +0200 @@ -1207,6 +1207,7 @@ void __user *, size_t *, loff_t *); unsigned long shrink_slab(unsigned long scanned, gfp_t gfp_mask, unsigned long lru_pages); +struct super_block; extern void drop_pagecache_sb(struct super_block *); void drop_pagecache(void); void drop_slab(void); You probably end up fixing it some other way, but as I do not know this file inside out I just wanted to drop a note. Yours, René Rebe On Tuesday 09 October 2007 22:54:30 Linus Torvalds wrote: > Finally. > > Yeah, it got delayed, not because of any huge issues, but because of > various bugfixes trickling in and causing me to reset my "release clock" > all the time. But it's out there now, and hopefully better for the wait. > > Not a whole lot of changes since -rc9, although there's a few updates to > mips, sparc64 and blackfin in there. Ignoring those arch updates, there's > basically a number of mostly one-liners (mostly in drivers, but there's > some networking fixes and soem VFS/VM fixes there too). > > Shortlog and diffstat appended (both relative to -rc9, of course - the > full log from 2.6.22 is on kernel.org as usual). > > I want this to be what people look at for a few days, but expect the x86 > merge to go ahead after that. So far, all indications are still that it's > going to be all smooth sailing, but hey, those indicators seem to always > say that, and only after the fact do people notice any problems ;) > > Linus -- René Rebe - ExactCODE GmbH - Europe, Germany, Berlin http://exactcode.de | http://t2-project.org | http://rene.rebe.name - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists