linux-kernel - RE: [PATCH] drivers/pci, drivers/dma: kill unused vars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 15 Oct 2007 09:05:18 -0700
From:	"Nelson, Shannon" <shannon.nelson@...el.com>
To:	"Jeff Garzik" <jeff@...zik.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>
Cc:	"LKML" <linux-kernel@...r.kernel.org>, "Greg KH" <greg@...ah.com>,
	"Williams, Dan J" <dan.j.williams@...el.com>
Subject: RE: [PATCH] drivers/pci, drivers/dma: kill unused vars

>-----Original Message-----
>From: Jeff Garzik [mailto:jeff@...zik.org] 
>Sent: Saturday, October 13, 2007 12:07 PM
>To: Andrew Morton; Linus Torvalds
>Cc: LKML; Greg KH; Nelson, Shannon; Williams, Dan J
>Subject: [PATCH] drivers/pci, drivers/dma: kill unused vars
>
>
>Kill two never-used (not even in hidden debug macros) variables,
>noticed by the compiler.
>
>Signed-off-by: Jeff Garzik <jgarzik@...hat.com>
>---
> drivers/dma/ioatdma.c                  |    1 -
> drivers/pci/hotplug/pci_hotplug_core.c |    2 --
> 2 files changed, 3 deletions(-)
>
>diff --git a/drivers/dma/ioatdma.c b/drivers/dma/ioatdma.c
>index 41b18c5..d9db64b 100644
>--- a/drivers/dma/ioatdma.c
>+++ b/drivers/dma/ioatdma.c
>@@ -244,7 +244,6 @@ static void 
>ioat_dma_free_chan_resources(struct dma_chan *chan)
> 	struct ioat_dma_chan *ioat_chan = to_ioat_chan(chan);
> 	struct ioat_device *ioat_device = to_ioat_device(chan->device);
> 	struct ioat_desc_sw *desc, *_desc;
>-	u16 chanctrl;
> 	int in_use_descs = 0;
> 
> 	ioat_dma_memcpy_cleanup(ioat_chan);

Acked-by: Shannon Nelson <shannon.nelson@...el.com>

FYI - this code gets heavily revised by ioat patches in -mm that Andrew
is planning on merging soon.

sln

>diff --git a/drivers/pci/hotplug/pci_hotplug_core.c 
>b/drivers/pci/hotplug/pci_hotplug_core.c
>index f0eba53..01c351c 100644
>--- a/drivers/pci/hotplug/pci_hotplug_core.c
>+++ b/drivers/pci/hotplug/pci_hotplug_core.c
>@@ -689,8 +689,6 @@ int pci_hp_deregister (struct hotplug_slot *slot)
> int __must_check pci_hp_change_slot_info(struct hotplug_slot *slot,
> 					 struct hotplug_slot_info *info)
> {
>-	int retval;
>-
> 	if ((slot == NULL) || (info == NULL))
> 		return -ENODEV;
> 
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/