linux-kernel - Re: [PATCH 2.6.23] oProfile: op_model_athalon.c support for AMD Family10h (Barcelona) Performance Counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071015174802.GS11245@erda.amd.com>
Date:	Mon, 15 Oct 2007 19:48:03 +0200
From:	"Robert Richter" <robert.richter@....com>
To:	"Barry Kasindorf" <barry.kasindorf@....com>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.23] oProfile: op_model_athalon.c support for AMD
 Family10h (Barcelona) Performance Counters

On 15.10.07 13:00:27, Barry Kasindorf wrote:
> 
> oProfile Driver Module Patch for AMD Family10h Kernel 2.6.23
> This patch is for controlling the upper 32bits of the event ctrl msrs.
> This includes the upper 4 bits of the event select and the Guest Only 
> and Host Only bits
> This patch is necessary to make Event Based Profiling work reliably on a 
> Family10h processor
> 
> ---
>  op_model_athlon.c |   22 ++++++++++++++++------
>  1 file changed, 16 insertions(+), 6 deletions(-)
> ---
> 
> Signed-off-by: Barry Kasindorf <barry.kasindorf@....com>
> Signed-off-by: Robert Richter <robert.richter@....com>
> 
> diff -Naur linux-2.6.23.orig/arch/i386/oprofile/op_model_athlon.c 
> linux-2.6.23.pmc/arch/i386/oprofile/op_model_athlon.c
> --- linux-2.6.23.orig/arch/i386/oprofile/op_model_athlon.c	2007-10-09 
> 16:31:38.000000000 -0400
> +++ linux-2.6.23.pmc/arch/i386/oprofile/op_model_athlon.c	2007-10-15 
> 11:02:39.000000000 -0400

[]

> @@ -70,7 +74,8 @@
>  		if (unlikely(!CTRL_IS_RESERVED(msrs,i)))
>  			continue;
>  		CTRL_READ(low, high, msrs, i);
> -		CTRL_CLEAR(low);
> +		CTRL_CLEAR_LO(low);
> +		CTRL_CLEAR_HI(low);

Should be probably this:

CTRL_CLEAR_HI(high);

>  		CTRL_WRITE(low, high, msrs, i);
>  	}
> 

[]

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@....com


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/