linux-kernel - RE: [PATCH 2.6.23]ata_piix: SATA 2port controller port map fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 15 Oct 2007 14:33:55 -0700
From:	"Gaston, Jason D" <jason.d.gaston@...el.com>
To:	"Jeff Garzik" <jgarzik@...ox.com>
Cc:	<linux-ide@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<htejun@...il.com>
Subject: RE: [PATCH 2.6.23]ata_piix: SATA 2port controller port map fix

>this was full of spaces, and should be converted to tabs (I did this
>manually)
>
>In the future, make sure to run your patch through
>scripts/checkpatch.pl.  Some of that script's complaints are a bit
>insane, but most are good.
>
>>  static const struct piix_map_db *piix_map_db_table[] = {
>>  	[ich5_sata]		= &ich5_map_db,
>>  	[ich6_sata]		= &ich6_map_db,
>> @@ -463,6 +476,7 @@
>>  	[ich6m_sata_ahci]	= &ich6m_map_db,
>>  	[ich8_sata_ahci]	= &ich8_map_db,
>>  	[tolapai_sata_ahci]	= &tolapai_map_db,
>> +	[ich9_2port_sata]	= &ich9_2port_map_db,
>>  };
>>
>>  static struct ata_port_info piix_port_info[] = {
>> @@ -587,6 +601,17 @@
>>  		.udma_mask	= ATA_UDMA6,
>>  		.port_ops	= &piix_sata_ops,
>>  	},
>> +
>> +	/* ich9_2port_sata: 12: */
>
>changed this to
>
>	[ich9_2port_sata] =
>
>since we have started using the (C99? gcc?) method of initializing
>piix_port_info[] array entries based on the given index, rather than
>simply noting the index in a comment and depending on the order of
other
>entries not to change.
>
>	Jeff

Thank you Jeff!  I guess it is time to switch email clients, as this one
keeps trashing my file import.  I thought I had it worked out, guess
not.  

Thanks again,

Jason
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/