linux-kernel - Re: [PATCH 3/3] Blackfin serial driver: this driver enable SPORTs on Blackfin emulate UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Oct 2007 18:03:35 -0400
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Andrew Morton" <akpm@...ux-foundation.org>
Cc:	"Bryan Wu" <bryan.wu@...log.com>, dmitry.torokhov@...il.com,
	linux-input@...ey.karlin.mff.cuni.cz,
	linux-joystick@...ey.karlin.mff.cuni.cz,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] Blackfin serial driver: this driver enable SPORTs on Blackfin emulate UART

On 10/15/07, Andrew Morton <akpm@...ux-foundation.org> wrote:
> > +config SERIAL_BFIN_SPORT
> > +     tristate "Blackfin SPORT emulate UART (EXPERIMENTAL)"
> > +     depends on BFIN && EXPERIMENTAL
> > +     select SERIAL_CORE
> > +     help
> > +       Enble support SPORT emulate UART on Blackfin series.
>
> There's a typo there.  Also the text is pretty meaningless - I'd fix it up
> but I'm not sure what it's trying to tell us!

here it is in english ;)

This driver emulates a standard UART using the SPORT peripherals on a
Blackfin processor.

> > +     snprintf(buffer, 20, "%s rx", up->name);
> > +     retval = request_irq(up->rx_irq, sport_uart_rx_irq, IRQF_SAMPLE_RANDOM, buffer, up);
> > +     if (retval) {
> > +             printk(KERN_ERR "Unable to request interrupt %s\n", buffer);
> > +             return retval;
> > +     }
> > +
> > +     snprintf(buffer, 20, "%s tx", up->name);
> > +     retval = request_irq(up->tx_irq, sport_uart_tx_irq, IRQF_SAMPLE_RANDOM, buffer, up);
> > +     if (retval) {
> > +             printk(KERN_ERR "Unable to request interrupt %s\n", buffer);
> > +             goto fail1;
> > +     }
> > +
> > +     snprintf(buffer, 20, "%s err", up->name);
> > +     retval = request_irq(up->err_irq, sport_uart_err_irq, IRQF_SAMPLE_RANDOM, buffer, up);
> > +     if (retval) {
> > +             printk(KERN_ERR "Unable to request interrupt %s\n", buffer);
> > +             goto fail2;
> > +     }
>
> It is not a good idea to create files in /proc which have spaces in their
> names.  Yes, userspace _should_ be able to cope with that in all cases, but
> all software sucks, even including userspace ;)
>
> I'd suggest that we be defensive here, and avoid using spaces in filenames.

i'm not sure i follow ... these are the names given to request_irq()
which means this is what shows up in /proc/interrupts ... does this
function also create an actual file somewhere in /proc that i am not
aware of ?

the rest of the comments look good to me, thanks !
-mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/