linux-kernel - Re: [patch] forcedeth: fix the NAPI poll function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Oct 2007 08:40:26 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	David Miller <davem@...emloft.net>, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, shemminger@...ux-foundation.org
Subject: Re: [patch] forcedeth: fix the NAPI poll function


* Jeff Garzik <jeff@...zik.org> wrote:

> >>The compiler certainly doesn't care, and IMO it prevents bugs.
> >
> >agreed. Do you have an uptodate patch/git-URI for the forcedeth 
> >rewrite you did? I can throw it into the testbed.
> 
> Branch 'fe-lock' of
> git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
> 
> It works here locally, but at this very minute I am rewriting those 
> changesets yet again :)

FYI, looks good so far, ontop of Linus' latest -git tree.

btw., one thing i always found weird about forcedeth is that it 
generates an extra ~100 irqs per second even when there's no network 
traffic:

 11:      89752    XT-PIC-XT        eth0
 11:      89854    XT-PIC-XT        eth0
 11:      89955    XT-PIC-XT        eth0
 11:      90056    XT-PIC-XT        eth0
 11:      90157    XT-PIC-XT        eth0

(irq count snapshot every second). Just in case it's easy to fix ...

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/