lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Oct 2007 14:11:13 +1000 From: Benjamin Herrenschmidt <benh@...nel.crashing.org> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Herbert Xu <herbert@...dor.apana.org.au>, akpm@...ux-foundation.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linuxppc-dev@...abs.org, Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de> Subject: Re: [PATCH] synchronize_irq needs a barrier > > repeat: > /* Optimistic, no-locking loop */ > while (desc->status & IRQ_INPROGRESS) > cpu_relax(); > > /* Ok, that indicated we're done: double-check carefully */ > spin_lock_irqsave(&desc->lock, flags); > status = desc->status; > spin_unlock_irqrestore(&desc->lock, flags); > > /* Oops, that failed? */ > if (status & IRQ_INPROGRESS) > goto repeat; > > Hmm? Paulus and I convinced ourselves that this would work. If we call our variable that gets set before synchronize_irq and read in the IRQ handler "foo", we get to: - writing foo can travel down at most to just before the unlock in the code above - reading foo can travel up out of the IRQ handler at most just after the lock in the code that sets IRQ_INPROGRESS. The whole lock/set IRQ_INPROGRESS/unlock path can then only happen before the locked section above, in which case we see and wait nicely and all is good, or after, in which case the store to foo will be visible to the IRQ handler as it will be ordered with the unlock in the code above. Pfiew ! So Acked-by: Benjamin Herrenschmidt <benh@...nel.crashing.org> Thanks ! Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists