linux-kernel - Re: msync(2) bug(?), returns AOP_WRITEPAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Oct 2007 11:05:14 +0300
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	"Hugh Dickins" <hugh@...itas.com>
Cc:	"Erez Zadok" <ezk@...sunysb.edu>, "Ryan Finnie" <ryan@...nie.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	cjwatson@...ntu.com, linux-mm@...ck.org, neilb@...e.de
Subject: Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

Hi Hugh,

On 10/25/07, Hugh Dickins <hugh@...itas.com> wrote:
> @@ -349,10 +349,6 @@ static pageout_t pageout(struct page *pa
>                 res = mapping->a_ops->writepage(page, &wbc);
>                 if (res < 0)
>                         handle_write_error(mapping, page, res);
> -               if (res == AOP_WRITEPAGE_ACTIVATE) {
> -                       ClearPageReclaim(page);
> -                       return PAGE_ACTIVATE;
> -               }

I don't see ClearPageReclaim added anywhere. Is that done on purpose?
Other than that, the patch looks good to me and I think we should
stick it into -mm to punish Andrew for his secret hack ;-).

                                          Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/