linux-kernel - Re: [PATCH 2/5] Use macros instead of TASK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Oct 2007 18:33:26 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	willy@...ux.intel.com, Stephane Eranian <eranian@....hp.com>
Subject: Re: [PATCH 2/5] Use macros instead of TASK_ flags

On Sat, Oct 27, 2007 at 12:39:41AM +0400, Alexey Dobriyan wrote:
> > > -		if ((task->state != TASK_STOPPED) && (task->state != TASK_TRACED)) {
> > > +		if (!is_task_stopped_or_traced(task)) {
>                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> I think this is horrible. Are you going to add full blown static inline
> function for every combination of state tests?

No, because we don't need them.  Just stopped, traced, stopped_or_traced.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/