linux-kernel - RE: [PATCH resend] Make the dev_*() family of macros in device.hcomplete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Oct 2007 05:11:24 -0700
From:	"Medve Emilian-EMMEDVE1" <Emilian.Medve@...escale.com>
To:	"Greg KH" <gregkh@...e.de>
Cc:	<mochel@...l.org>, <linux-kernel@...r.kernel.org>, <hjlipp@....de>,
	<tilman@...p.cc>, <gigaset307x-common@...ts.sourceforge.net>,
	<kkeil@...e.de>, <isdn4linux@...tserv.isdn4linux.de>,
	<mac@...ware.de>, <linux-omap-open-source@...ux.omap.com>
Subject: RE: [PATCH resend] Make the dev_*() family of macros in device.hcomplete

Hi Greg K-H,

> > +#define dev_info(dev, format, arg...)		\
> > +	dev_printk(KERN_INFO, dev, format, ## arg)
> > +
> >  #ifdef DEBUG
> >  #define dev_dbg(dev, format, arg...)		\
> > -	dev_printk(KERN_DEBUG , dev , format , ## arg)
> > +	dev_printk(KERN_DEBUG, dev, format, ## arg)
> 
> Those extra spaces are there for a good reason, older versions of gcc
> are broken without it.  So please, put them all back...

You mean I should add spaces before commas only where they were
initially or to all new code and/or macros? I've observed other kernel
code and more often there are no spaces before commas. I'm asking
because the CodingStyle document is not very explicit about this rule.

Thank you,
Emil.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/