linux-kernel - User Mode Linux still broken in 2.6.23.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 3 Nov 2007 23:51:50 -0500
From:	Rob Landley <rob@...dley.net>
To:	linux-kernel@...r.kernel.org
Cc:	Jeff Dike <jdike@...toit.com>, akpm@...ux-foundation.org,
	Greg KH <greg@...ah.com>, Chris Wright <chrisw@...s-sol.org>
Subject: User Mode Linux still broken in 2.6.23.1

Building with the attached .config on x86-64, it does this:

  CC      arch/um/kernel/smp.o
In file included from include/asm/arch/tlb.h:11,
                 from include/asm/tlb.h:4,
                 from arch/um/kernel/smp.c:8:
include/asm-generic/tlb.h: In function ‘tlb_flush_mmu’:
include/asm-generic/tlb.h:76: error: implicit declaration of function ‘release_pages’
include/asm-generic/tlb.h: In function ‘tlb_remove_page’:
include/asm-generic/tlb.h:105: error: implicit declaration of function ‘page_cache_release’
make[1]: *** [arch/um/kernel/smp.o] Error 1
make: *** [arch/um/kernel] Error 2

I've been doing the following to fix it.  I know it's not the right fix,
(see the earlier thread about it at http://lkml.org/lkml/2007/8/24/441 )
but could the one line fix go into the -stable queue 2.6.23 while a proper
fix goes into 2.6.24?

From: Rob Landley <rob@...dley.net>

Fix build break in User Mode Linux 2.6.23.1.

Signed-off-by: Rob Landley <rob@...dley.net>

---

 arch/um/kernel/smp.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-2.6.23-rc3/arch/um/kernel/smp.c
+++ linux-2.6.23-new/arch/um/kernel/smp.c
@@ -5,6 +5,7 @@

 #include "linux/percpu.h"
 #include "asm/pgalloc.h"
+#include "linux/pagemap.h"
 #include "asm/tlb.h"

 /* For some reason, mmu_gathers are referenced when CONFIG_SMP is off. */
-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

View attachment ".config" of type "text/plain" (5600 bytes)