lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 17 Nov 2007 02:15:05 +0100 (MET) From: Mikael Pettersson <mikpe@...uu.se> To: gregkh@...e.de, linux-kernel@...r.kernel.org, timur@...escale.com Subject: Re: Add a private_data pointer to struct device_attribute On Fri, 16 Nov 2007 18:11:00 -0600, Timur Tabi wrote: > A private data pointer in struct device_attribute allows the 'show' and 'store' > functions to access instance data. This handy in situations where the > driver_data and platform_data pointers of 'struct device' are already used > for other purposes. > > Signed-off-by: Timur Tabi <timur@...escale.com> > --- > > Greg, can you tell me if you think this patch is a good idea? It doesn't > appear to do any harm, and I'm working on an ALSA driver that could benefit > for this patch. I think 2.6.25 would be a good target. > > include/linux/device.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/linux/device.h b/include/linux/device.h > index 2e15822..10708ee 100644 > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -344,6 +344,7 @@ struct device_attribute { > char *buf); > ssize_t (*store)(struct device *dev, struct device_attribute *attr, > const char *buf, size_t count); > + void *private_data; > }; A common trick is to embed a generic struct inside a specific one containing add-on data fields, and then to map from the generic one to the specific one using container_of() in your ops (function pointers). This is both faster and less wasteful of memory than adding void *private all over the place. Any reason that won't work here? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists