lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Nov 2007 09:35:40 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Joe Perches <joe@...ches.com> Cc: Denis Cheng <crquan@...il.com>, linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org, dengxw@....com, Randy Dunlap <randy.dunlap@...cle.com> Subject: Re: [PATCH] [RESEND] crypto test: use print_hex_dump from <linux/kernel.h> instead On Mon, Nov 26, 2007 at 10:01:44AM -0800, Joe Perches wrote: > On Tue, 2007-11-27 at 01:28 +0800, Denis Cheng wrote: > > -static void hexdump(unsigned char *buf, unsigned int len) > > -{ > > - while (len--) > > - printk("%02x", *buf++); > > - > > - printk("\n"); > > -} > > #define hexdump(buf, len) \ > print_hex_dump(KERN_CONT, "", DUMP_PREFIX_NONE, 16, 1, \ > (buf), (len), false) > > requires no other changes. Yes that's a good idea. Denis could you do another patch with this, preferably as a static inline function? That way you don't even need to worry about test_aead. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists