lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Nov 2007 09:28:56 +0000 From: Al Viro <viro@....linux.org.uk> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Pierre Ossman <drzeus@...eus.cx>, Geert Uytterhoeven <geert@...ux-m68k.org>, Sam Ravnborg <sam@...nborg.org>, Marcel Holtmann <marcel@...tmann.org>, linux-kernel@...r.kernel.org Subject: Re: m68k build failure On Wed, Nov 28, 2007 at 01:00:56AM -0800, Andrew Morton wrote: > > No the slightest. 12 seems like the correct, padded size. A size of 10 is just weird as the unpadded size is 9 bytes. Could you dump the __mod_sdio_device_table section so we can determine if it is cropped or just oddly padded. > > > > err, I'd rather not. I have no shortage of bugs to be going on with here. > > http://userweb.kernel.org/~akpm/cross-compilers/ has the i386->m68k > cross-compiler which I use. Eh... m68k has 16bit alignment for unsigned long. diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h --- a/include/linux/mod_devicetable.h +++ b/include/linux/mod_devicetable.h @@ -343,7 +343,8 @@ struct sdio_device_id { __u8 class; /* Standard interface or SDIO_ANY_ID */ __u16 vendor; /* Vendor or SDIO_ANY_ID */ __u16 device; /* Device ID or SDIO_ANY_ID */ - kernel_ulong_t driver_data; /* Data private to the driver */ + kernel_ulong_t driver_data /* Data private to the driver */ + __attribute__((aligned(sizeof(kernel_ulong_t)))); }; /* SSB core, see drivers/ssb/ */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists