lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 2 Dec 2007 19:59:07 +0800 From: Denis Cheng <crquan@...il.com> To: Peter Zijlstra <a.p.zijlstra@...llo.nl>, Andrew Morton <akpm@...ux-foundation.org> Cc: stable@...nel.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: [PATCH] mm/backing-dev.c: fix percpu_counter_destroy call bug in bdi_init this call should use the array index j, not i: --- mm/backing-dev.c.orig 2007-12-02 19:42:57.000000000 +0800 +++ mm/backing-dev.c 2007-12-02 19:43:14.000000000 +0800 @@ -22,7 +22,7 @@ int bdi_init(struct backing_dev_info *bd if (err) { err: for (j = 0; j < i; j++) - percpu_counter_destroy(&bdi->bdi_stat[i]); + percpu_counter_destroy(&bdi->bdi_stat[j]); } return err; but with this approach, just one int i is enough, int j is not needed. Signed-off-by: Denis Cheng <crquan@...il.com> --- mm/backing-dev.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/backing-dev.c b/mm/backing-dev.c index b0ceb29..e8644b1 100644 --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -7,7 +7,7 @@ int bdi_init(struct backing_dev_info *bdi) { - int i, j; + int i; int err; for (i = 0; i < NR_BDI_STAT_ITEMS; i++) { @@ -21,7 +21,7 @@ int bdi_init(struct backing_dev_info *bdi) if (err) { err: - for (j = 0; j < i; j++) + while (i--) percpu_counter_destroy(&bdi->bdi_stat[i]); } -- 1.5.3.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists