lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 04 Dec 2007 00:33:52 -0800 (PST) From: David Miller <davem@...emloft.net> To: julia@...u.dk Cc: wli@...omorphy.com, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH 2/3] arch/sparc: Add missing of_node_put From: Julia Lawall <julia@...u.dk> Date: Sun, 2 Dec 2007 21:05:24 +0100 (CET) > From: Julia Lawall <julia@...u.dk> > > There should be an of_node_put when breaking out of a loop that iterates > using for_each_node_by_type. > > This was detected and fixed using the following semantic patch. > (http://www.emn.fr/x-info/coccinelle/) > > // <smpl> > @@ > identifier d; > type T; > expression e; > iterator for_each_node_by_type; > @@ > > T *d; > ... > for_each_node_by_type(d,...) > {... when != of_node_put(d) > when != e = d > ( > return d; > | > + of_node_put(d); > ? return ...; > ) > ...} > // </smpl> > > Signed-off-by: Julia Lawall <julia@...u.dk> Applied, but I had to fixup the trailing whitespace on this line: > - if (!err) > + if (!err) { As indicated by GIT: Adds trailing whitespace. diff:9: if (!err) { warning: 1 line adds whitespace errors. Please correct these kinds of errors before submitting in the future, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists