| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 4 Dec 2007 17:46:13 -0800 (PST) From: Linus Torvalds <torvalds@...ux-foundation.org> To: Steven Rostedt <rostedt@...dmis.org> cc: Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>, LKML <linux-kernel@...r.kernel.org>, David Holmes - Sun Microsystems <David.Holmes@....COM>, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: [PATCH] fix for futex_wait signal stack corruption On Tue, 4 Dec 2007, Steven Rostedt wrote: > > Since arg3 is out, which do you prefer? Creating an arg4 (and perhaps > more) in the block or having a u64 arg? Changing all the args to u64 may > be the best. I suspect that the best option is probably to make that thing a unnamed union of the actual different types the different restart cases needs, which also allows you to name things appropriately and not have any wasted space. Leave the arg0-3 ones around as one of the unions, both to avoid having to change other things and to have a "generic" one for stuff that simply doesn't much care (in order to not have tons and tons of substructures to the union when most users really don't need any fancy types). I think we already depend on recent-enough gcc's that unnamed unions are ok and we don't need to play games with naming. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists