linux-kernel - Re: [PATCH 2.6.24-rc4] proc: Remove/Fix proc generic d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Dec 2007 16:32:18 +0300
From:	"Denis V. Lunev" <den@...ru>
To:	Petr Vandrovec <vandrove@...cvut.cz>
CC:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alexey Dobriyan <adobriyan@...il.com>, rjw@...k.pl,
	trond.myklebust@....uio.no, gnome42@...il.com,
	linux-kernel@...r.kernel.org, bfields@...ldses.org, den@...nvz.org,
	Pavel Emelyanov <xemul@...nvz.org>
Subject: Re: [PATCH 2.6.24-rc4] proc: Remove/Fix proc generic d_revalidate

could you, plz, check patch sent by Eric above in this thread.

I have tried it on my test node and it works for module you have
provided. The problem exists without it.

Regards,
	Den

Petr Vandrovec wrote:
> Eric W. Biederman wrote:
>> Ultimately to implement /proc perfectly we need an implementation
>> of d_revalidate because files and directories can be removed behind
>> the back of the VFS, and d_revalidate is the only way we can let
>> the VFS know that this has happened.
>>
>> So until we get a proper test for keeping dentries in the dcache
>> fix the current d_revalidate method by completely removing it.  This
>> returns us to the current status quo.
> 
> Hello,
>    I know that I'm late to the party, but mount points is not only
> problem with d_revalidate.  With your patch in place module below gets
> refcount incremented by two every time I do 'ls -la /proc/fs/vmblock'.
> 
> 
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/proc_fs.h>
> 
> static int vmblockinit(void) {
>    struct proc_dir_entry *controlProcDirEntry;
> 
>    /* Create /proc/fs/vmblock */
>    controlProcDirEntry = proc_mkdir("vmblock", proc_root_fs);
>    if (!controlProcDirEntry) {
>       printk(KERN_DEBUG "Bad...\n");
>       return -EINVAL;
>    }
>    controlProcDirEntry->owner = THIS_MODULE;
>    return 0;
> }
> 
> static void vmblockexit(void) {
>    remove_proc_entry("vmblock", proc_root_fs);
> }
> 
> module_init(vmblockinit);
> module_exit(vmblockexit);
> 
> 
> (code comes from VMware's vmblock module,
> http://sourceforge.net/project/showfiles.php?group_id=204462)
>                         Thanks,
>                             Petr
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/