linux-kernel - Re: [PATCH 21/47] New version of CRISv32 I2C driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Dec 2007 03:19:05 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jesper Nilsson <jesper.nilsson@...s.com>
Cc:	Mikael Starvik <mikael.starvik@...s.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 21/47] New version of CRISv32 I2C driver.

On Fri, 30 Nov 2007 15:54:01 +0100 Jesper Nilsson <jesper.nilsson@...s.com> wrote:

> +int
> +i2c_write(unsigned char theSlave, void *data, size_t nbytes)
> +{
> +	int error, cntr = 3;
> +	unsigned char bytes_wrote = 0;
> +	unsigned char value;
> +	unsigned long flags;
> +
> +	spin_lock(&i2c_lock);
> +
> +	do {
> +		error = 0;
> +		/*
> +		 * we don't like to be interrupted
> +		 */
> +		local_irq_save(flags);
> +
> +		i2c_start();
> +		/*

Well if you _are_ interrupted prior to the local_irq_save() you'll deadlock
on i2c_lock?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/