[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 12 Dec 2007 03:43:25 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: "Joonwoo Park" <joonwpark81@...il.com>
Cc: "'Zhu Yi'" <yi.zhu@...el.com>,
<ipw3945-devel@...ts.sourceforge.net>,
<linux-wireless@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<netdev@...r.kernel.org>
Subject: Re: [PATCH 1/2] [net/wireless/iwlwifi] : iwlwifi 3945 Fix
raceconditional panic.
On Thu, 29 Nov 2007 10:42:49 +0900 "Joonwoo Park" <joonwpark81@...il.com> wrote:
> 2007/11/29, Zhu Yi <yi.zhu@...el.com>:
> >
> > Good catch. But it will be better if you add it into
> > iwl_cancel_deferred_work().
> >
>
> Thanks.
> I agree with you.
> Actually, I considered it, but I was afraid of side effect.
> Anyway, I'm attaching a new one.
>
> Thanks.
> Joonwoo
>
> [net/wireless/iwlwifi] : iwlwifi 3945 Fix race conditional panic.
>
> Signed-off-by: Joonwoo Park <joonwpark81@...il.com>
> ---
> diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> index 465da4f..e51e872 100644
> --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
> +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> @@ -8270,6 +8270,7 @@ static void iwl_cancel_deferred_work(struct iwl_priv *priv)
> {
> iwl_hw_cancel_deferred_work(priv);
>
> + cancel_delayed_work_sync(&priv->init_alive_start);
> cancel_delayed_work(&priv->scan_check);
> cancel_delayed_work(&priv->alive_start);
> cancel_delayed_work(&priv->post_associate);
Did drivers/net/wireless/iwlwifi/iwl4965-base.c get fixed in a simlar
fashion?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists