linux-kernel - Re: [PATCH] fbcon: fix sparse warning about shadowing 'p' symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Dec 2007 11:23:21 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	marcin.slusarz@...il.com, linux-kernel@...r.kernel.org,
	adaplas@...il.com
Subject: Re: [PATCH] fbcon: fix sparse warning about shadowing 'p' symbol

From: Andrew Morton <akpm@...ux-foundation.org>
Date: Tue, 11 Dec 2007 16:57:00 -0800

> On Sun, 9 Dec 2007 22:34:33 +0100
> Marcin __lusarz <marcin.slusarz@...il.com> wrote:
> 
> > fbcon: fix sparse warning about shadowing 'p' symbol
> > 
> 
> Please always quote error messages and warnings in the changelog when
> fixing them, thanks.
> 
> > ---
> >  drivers/video/console/fbcon.c |   10 +++++-----
> >  1 files changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> > index 0f32f4a..849e114 100644
> > --- a/drivers/video/console/fbcon.c
> > +++ b/drivers/video/console/fbcon.c
> > @@ -2795,7 +2795,7 @@ static int fbcon_scrolldelta(struct vc_data *vc, int lines)
> >  {
> >  	struct fb_info *info = registered_fb[con2fb_map[fg_console]];
> >  	struct fbcon_ops *ops = info->fbcon_par;
> > -	struct display *p = &fb_display[fg_console];
> > +	struct display *disp = &fb_display[fg_console];
> 
> We have a global symbol called "p"?  That would be bad.  Where is it?

I'm curious about this too.

Ahh, I see, look down a few lines in fbcon_scrolldelta(), we have:

			if (logo_shown == vc->vc_num) {
				unsigned long p, q;
				int i;

and that's where the warning is coming from.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/