linux-kernel - Re: [PATCH 2/2] power: fix incorrect unregistration in power_supply_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 12 Dec 2007 22:52:49 +0300
From:	Anton Vorontsov <avorontsov@...mvista.com>
To:	Andres Salomon <dilinger@...ued.net>
Cc:	linux-kernel@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>,
	akpm@...ux-foundation.org, cbou@...l.ru
Subject: Re: [PATCH 2/2] power: fix incorrect unregistration in power_supply_create_attrs error path

On Wed, Dec 12, 2007 at 02:12:59PM -0500, Andres Salomon wrote:
> 
> In power_supply_create_attrs(), we create static attributes as referenced
> by power_supply_static_attrs[i].  After that, if we fail, we unregister
> via power_supply_static_attrs[psy->properties[i]].  This is incorrect, as
> psy->properties has absolutely no bearing on static attribs.  This patch
> fixes it to unregister the correct attrib.
> 
> Another line which was unnecessarily line wrapped is also unwrapped.

Will apply to battery-2.6.git, and will try to push this into 2.6.24.

Much thanks.

> Signed-off-by: Andres Salomon <dilinger@...ian.org>
> ---
>  drivers/power/power_supply_sysfs.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
> index 0331e82..8efedba 100644
> --- a/drivers/power/power_supply_sysfs.c
> +++ b/drivers/power/power_supply_sysfs.c
> @@ -153,8 +153,7 @@ dynamics_failed:
>  			   &power_supply_attrs[psy->properties[j]]);
>  statics_failed:
>  	while (i--)
> -		device_remove_file(psy->dev,
> -			   &power_supply_static_attrs[psy->properties[i]]);
> +		device_remove_file(psy->dev, &power_supply_static_attrs[i]);
>  succeed:
>  	return rc;
>  }
> @@ -164,8 +163,7 @@ void power_supply_remove_attrs(struct power_supply *psy)
>  	int i;
>  
>  	for (i = 0; i < ARRAY_SIZE(power_supply_static_attrs); i++)
> -		device_remove_file(psy->dev,
> -			    &power_supply_static_attrs[i]);
> +		device_remove_file(psy->dev, &power_supply_static_attrs[i]);
>  
>  	for (i = 0; i < psy->num_properties; i++)
>  		device_remove_file(psy->dev,
> -- 
> 1.5.3.5
> 
> 

-- 
Anton Vorontsov
email: cbou@...l.ru
backup email: ya-cbou@...dex.ru
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/