linux-kernel - Re: [PATCH 1/4] x86: clean up asm-x86/page*.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 14 Dec 2007 07:46:14 -0800
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jan Beulich <jbeulich@...ell.com>,
	Glauber de Oliveira Costa <glommer@...il.com>
Subject: Re: [PATCH 1/4] x86: clean up asm-x86/page*.h

Ingo Molnar wrote:
> * Jeremy Fitzhardinge <jeremy@...p.org> wrote:
>
>   
>> Unify common definitions in page*.h.  To simplify other code, I added 
>> typedefs for the value of pte/pmd/pud/pgd values, so they can be used 
>> symbolically elsewhere without needing to have lots of 32/64/PAE 
>> tests.
>>
>> Also, add PAGETABLE_LEVELS define so that other definitions can test 
>> for it directly rather than using indirect 32/64/PAE tests.
>>     
>
> this one introduces mass warnings of:
>
>  include/asm/page.h: In function 'copy_page':
>  include/asm/page.h:34: warning: passing argument 2 of 'mmx_copy_page' discards qualifiers from pointer target type
>  In file included from include/asm/thread_info_32.h:14,
>                  from include/asm/thread_info.h:3,
>                  from include/linux/thread_info.h:35,
>                  from include/linux/preempt.h:10,
>                  from include/linux/spinlock.h:50,
>                  from include/linux/mmzone.h:8,
>                  from include/linux/gfp.h:5,
>                  from include/linux/mm.h:9,
>                  from arch/x86/mm/mmap.c:29:
>
> with the attached config.
>   

Hm.  I constified the "from" argument to copy_page on the way through
(to catch param-swapping problems).  Looks like I need to update
mmx_copy_page etc as well.  Anyway, this warning is harmless, and I'll
generate a separate patch to fix it.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/