linux-kernel - [PATCH drivers/isdn/hardware/eicon/message.c] fix 'and' typo in eicons' AddInfo()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 17 Dec 2007 17:05:28 +0100
From:	Roel Kluin <12o3l@...cali.nl>
To:	mac@...ware.de
CC:	isdn4linux@...tserv.isdn4linux.de,
	lkml <linux-kernel@...r.kernel.org>
Subject: [PATCH drivers/isdn/hardware/eicon/message.c] fix 'and' typo in eicons'
 AddInfo()

I have previously sent this to isdn4linux@...tserv.isdn4linux.de and its
maintainer, but the error is still in linus' tree.
--
'!' has a higher priority than '&', so as was the bit test masks a binary.

Signed-off-by: Roel Kluin <12o3l@...cali.nl>
---
diff --git a/drivers/isdn/hardware/eicon/message.c b/drivers/isdn/hardware/eicon/message.c
index ccd35d0..189b231 100644
--- a/drivers/isdn/hardware/eicon/message.c
+++ b/drivers/isdn/hardware/eicon/message.c
@@ -9027,7 +9027,7 @@ static byte AddInfo(byte   **add_i,
    /* facility is a nested structure */
    /* FTY can be more than once      */
 
-  if(esc_chi[0] && !(esc_chi[esc_chi[0]])&0x7f )
+	if (esc_chi[0] && !(esc_chi[esc_chi[0]] & 0x7f))
   {
     add_i[0] = (byte   *)"\x02\x02\x00"; /* use neither b nor d channel */
   }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/