linux-kernel - checkpatch false ERROR: trailing statements should be on next line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Dec 2007 16:50:04 -0500
From:	Erez Zadok <ezk@...sunysb.edu>
To:	apw@...dowen.org, linux-kernel@...r.kernel.org
Subject: checkpatch false ERROR: trailing statements should be on next line

Using v2.6.24-rc6-125-g5356f66, code such as this:

	if (is_file)	/* dirs can be unlinked but chdir'ed to */
		err = -ESTALE;

produces this false checkpatch error:

	foo.c:947: ERROR: trailing statements should be on next line

I think comments such as the above should be allowed (plus a comment isn't a
statement).  It's often very useful to put them right on the affected line.

Thanks,
Erez.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/