linux-kernel - [PATCH] remove val in __do_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 28 Dec 2007 09:52:46 +0900
From:	Tomohiro Kusumi <kusumi.tomohiro@...fujitsu.com>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH] remove val in __do_proc_dointvec

Hi

What's the purpose of the val in __do_proc_dointvec ?
It seems no one ever uses this val.

Tomohiro Kusumi
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@...fujitsu.com>

diff -Nur linux-2.6.23.org/kernel/sysctl.c linux-2.6.23/kernel/sysctl.c
--- linux-2.6.23.org/kernel/sysctl.c	2007-12-28 09:29:18.000000000 +0900
+++ linux-2.6.23/kernel/sysctl.c	2007-12-28 09:31:32.000000000 +0900
@@ -1716,7 +1716,7 @@
 		  void *data)
 {
 #define TMPBUFLEN 21
-	int *i, vleft, first=1, neg, val;
+	int *i, vleft, first=1, neg;
 	unsigned long lval;
 	size_t left, len;
 	
@@ -1769,8 +1769,6 @@
 			len = p-buf;
 			if ((len < left) && *p && !isspace(*p))
 				break;
-			if (neg)
-				val = -val;
 			s += len;
 			left -= len;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/