lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 28 Dec 2007 13:54:51 +0100 From: Andi Kleen <ak@...e.de> To: travis@....com Cc: Andrew Morton <akpm@...ux-foundation.org>, Christoph Lameter <clameter@....com>, linux-mm@...ck.org, linux-kernel@...r.kernel.org, Rusty Russell <rusty@...tcorp.com.au>, tglx@...utronix.de, mingo@...hat.com Subject: Re: [PATCH 05/10] x86_64: Use generic percpu On Friday 28 December 2007 01:10:51 travis@....com wrote: > x86_64 provides an optimized way to determine the local per cpu area > offset through the pda and determines the base by accessing a remote > pda. And? The rationale for this patch seems to be incomplete. As far as I can figure out you're replacing an optimized percpu implementation which a dumber generic one. Which needs at least some description why. If the generic one is now as good or better than the specific one that might be ok, but that should be somewhere in the description. Also for such changes .text size comparisons before/after are a good idea. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists