linux-kernel - Re: [PATCH] x86: unify x86 Makefile(s)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 29 Dec 2007 13:16:07 +0100
From:	Andi Kleen <ak@...e.de>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Sam Ravnborg <sam@...nborg.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: unify x86 Makefile(s)

If -funit-at-a-time really increases stack size too much on some compiler
version the right fix would be to check where it does that using make checkstack
and then add "noinline" attributes there to prevent the compiler from inlining.
That would prevent them.

Globally disabling it is too big a hammer.

e.g. I know XFS did it in a similar way to prevent this problem.

So I would reenable it for now and if you know it causes problems on specific
compiler versions, Adrian, you could watch make checkstack there and submit
noinline patches as needed.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/