| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 01 Jan 2008 14:44:48 +0100 From: Andreas Schwab <schwab@...e.de> To: Sam Ravnborg <sam@...nborg.org> Cc: WANG Cong <xiyou.wangcong@...il.com>, Ralf Baechle <ralf@...ux-mips.org>, LKML <linux-kernel@...r.kernel.org>, linux-kbuild@...r.kernel.org, Andrew Morton <akpm@...l.org>, linux-mips@...ux-mips.org Subject: Re: [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles Sam Ravnborg <sam@...nborg.org> writes: >> @@ -24,7 +24,7 @@ HEAD_DEFINES := -D_kernel_start=0x$(KERNEL_START) \ >> -D TIMESTAMP=$(shell date +%s) >> >> $(obj)/head.o: $(obj)/head.S $(KERNEL_IMAGE) >> - $(CC) -fno-pic $(HEAD_DEFINES) -I$(TOPDIR)/include -c -o $@ $< >> + $(CC) -fno-pic $(HEAD_DEFINES) -I$(objtree)/include -c -o $@ $< > This has never worked with O=.. builds. > The correct fix here is to use: >> + $(CC) -fno-pic $(HEAD_DEFINES) -Iinclude -Iinclude2 -c -o $@ $< > > The -Iinclude2 is only for O=... builds so to keep current > behaviour removing $(TOPDIR)/ would do it. Shouldn't that use $(LINUXINCLUDE), or $(KBUILD_CPPFLAGS)? Andreas. -- Andreas Schwab, SuSE Labs, schwab@...e.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists