linux-kernel - Re: PATCH] adding wistron_btns support for X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 3 Jan 2008 11:21:55 -0500
From:	"Dmitry Torokhov" <dmitry.torokhov@...il.com>
To:	"Rémi Hérilier" <rherilier@...oo.fr>
Cc:	"Carlos Corbacho" <carlos@...angeworlds.co.uk>,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: PATCH] adding wistron_btns support for X86_64 systems.

Hi Rémi,

On Jan 2, 2008 5:31 PM, Rémi Hérilier <rherilier@...oo.fr> wrote:
> Carlos Corbacho wrote:
> > (CC'ing linux-input, as that is the relevant subsystem list for wistron-btns).
> >
> > Rémi Hérilier wrote:
> >> To use my previous patch (wistron_btns support for fujitsu-siemens amilo
> >> pro edition v3505) with my laptop, I need to make the wistron module
> >> compile for x86_64. It is based on Linux 2.4.24-rc4 too.
> >
> > NAK.
> >
> > You cannot make 32 bit BIOS calls in a 64 bit OS.
> >
> > This will (and does) segfault on x86-64 (tested on my Aspire 5020, where
> > call_bios wistron-btns just segfaults on x86-64 with this patch).
> >
> > This is a known issue, and the reason why wistron-btns (and the out-of-tree
> > acerhk) have not been ported to x86-64.
> >
> > -Carlos
>
> Yes, in theory, this must segfault on x86-64.
>
> In pratice, there is one laptop where it seems to works (no problem
> for 3 weeks). A good reason to find why.
>

My concern that even on that particular model this may stop wotking if
you upgrade BIOS. Otherwise the fact that it doe snot work on some
other laptop should not stop us - we using DMI matching in wistron
buttons anyway.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/