linux-kernel - Re: [RESEND PATCH 09/10] ide-floppy: use test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 5 Jan 2008 17:10:58 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Borislav Petkov <bbpetkov@...oo.de>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH 09/10] ide-floppy: use test_bit wrappers for testing flags


There are two issues here:

* set_bit()/test_bit() are atomic operations and they don't see to be
  necessary in case of ide-floppy.c (standard '|'/'&' should be enough)

* using wrappers for these operations is not a bad idea but doing it _now_
  just makes it harder for us to figure out how to introduced common ATA
  Packet command interface for all ATAPI device drivers (the other drivers
  are using very similar flag handling and flag names currently)

so I would say that we should defer introducting these wrappers for now
(patch converting set_bit()/test_bit() to '|'/'&' would still be welcomed).

On Thursday 03 January 2008, Borislav Petkov wrote:
> also, fix header comments and remove superfluous ones. There should be no
> functionality change resulting from this patch.

fixes for comments look fine but they should be merged with the other
patch (the one containing checkpatch.pl/comments fixes)

Thanks,
Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/