linux-kernel - Re: [patch 1/3] move WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 05 Jan 2008 13:35:12 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	arjan@...ux.intel.com (Arjan van de Ven)
Cc:	mpm@...enic.com, linux-kernel@...r.kernel.org, mingo@...e.hu,
	akpm@...ux-foundation.org
Subject: Re: [patch 1/3] move WARN_ON() out of line

Arjan van de Ven <arjan@...ux.intel.com> wrote:
>
>> While we're here, I'll mention that dump_stack probably ought to take a
>> severity level argument.
> 
> 125 files changed, 202 insertions(+), 199 deletions(-)
> just to get the api change done.
> I can hear akpm cringe from here...

You don't have to change all of them at once.  Just create a new function
that does take a level and make the old dump_stack and WARN_ON call that
then slowly convert everything else across if so desired.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/